-
The trailing comma for function arguments, introduced in [1], isn't supported in PHP 7.4, resulting in a ParseError:
That's why the pipeline also fails for 7.4 [2]. I also wonder how a failing pipeline allows for a release? [1] https://github.com/spatie/icalendar-generator/pull/104/files#diff-12ca5b67c9f5fef1d4b4134cff800aa328f9af9cb98fa2fbdc851da74ca8cfefR14 |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 2 replies
-
We have found this exact issue also. Needing to rollback to earlier version to account for this. |
Beta Was this translation helpful? Give feedback.
-
I've tagged a new release that fixes the syntax error on PHP 7.4 There are a couple of more tests failing which I don't have time to fix them now (I would appreciate a PR) |
Beta Was this translation helpful? Give feedback.
-
Unfortunately 2.5.3 fixes only the one occurrence. I probably should have linked them all. I'm looking into providing a PR. EDIT: #106 |
Beta Was this translation helpful? Give feedback.
Unfortunately 2.5.3 fixes only the one occurrence. I probably should have linked them all. I'm looking into providing a PR.
EDIT: #106
EDIT: PR got merged and 2.5.4 released