Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Scotland, North Ireland, Wales, England to UK #257

Open
arnebr opened this issue Dec 23, 2024 · 0 comments
Open

Merge Scotland, North Ireland, Wales, England to UK #257

arnebr opened this issue Dec 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@arnebr
Copy link
Contributor

arnebr commented Dec 23, 2024 •
edited
Loading

What happened?

Currently the Holidays for Scotland, North Ireland, Wales, England are each in a separate Country Class, this could be merged to a single class with the name United Kingdom and country code GB and then using the subdivision code with the region logic. Otherwise its defeats the purpose of the regional logic in other countries. Will try to introduce a PR.

How to reproduce the bug

Package Version

1.16.0

PHP Version

8.X

Which operating systems does with happen with?

No response

Notes

No response
@arnebr arnebr added the bug Something isn't working label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arnebr