-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why so many generated structures with hydrogen and/or helium? #80
Comments
xref: txie-93/cdvae#11 |
Doesn't seem to be an issue with noble gases being represented very frequently, which of course isn't expected anyway since it's experimentally verified compounds. Maybe
from pymatviz.elements import ptable_heatmap_plotly
equimolar_compositions = train_inputs.apply(
lambda s: Composition(re.sub(r"\d", "", s.formula))
)
fig = ptable_heatmap_plotly(equimolar_compositions)
fig.show() |
Also strange that there's not a single instance of oxygen in the generated structures, despite its prevalence. I don't see "adjacent" elements nitrogen or flourine either. Could be an issue with the scaling/unscaling, not enough data, bad model, bad representation, or biased sample. Last one seems unlikely. Probably not an issue with data shuffling #84 |
from #79
Interested to see how it goes with |
See also #79
The text was updated successfully, but these errors were encountered: