Skip to content

Commit 2c95fa4

Browse files
authored
Bump CI runner to Xcode 16.1 / macOS 15 (#2659)
1 parent 8fcdac1 commit 2c95fa4

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

.github/workflows/ci.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,18 @@ jobs:
1010
build:
1111
strategy:
1212
matrix:
13-
xcode: ['xcode16', 'xcode15.4']
13+
xcode: ['xcode16.1', 'xcode15.4']
1414
include:
1515
- xcode: 'xcode15.4'
1616
xcode-path: '/Applications/Xcode_15.4.app/Contents/Developer'
17-
upload-dist: true
18-
run-analyzer: true
19-
macos: 'macos-14'
20-
- xcode: 'xcode16'
21-
xcode-path: '/Applications/Xcode_16.app'
2217
upload-dist: false
2318
run-analyzer: false
2419
macos: 'macos-14'
20+
- xcode: 'xcode16.1'
21+
xcode-path: '/Applications/Xcode_16.1.app'
22+
upload-dist: true
23+
run-analyzer: true
24+
macos: 'macos-15'
2525

2626
name: Build and Test Sparkle
2727
runs-on: ${{ matrix.macos }}

.github/workflows/create-draft-release.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: "Create Draft Release"
22

33
env:
44
BUILDDIR: "build"
5-
DEVELOPER_DIR: "/Applications/Xcode_15.4.app/Contents/Developer"
5+
DEVELOPER_DIR: "/Applications/Xcode_16.1.app/Contents/Developer"
66

77
on:
88
workflow_dispatch:
@@ -29,7 +29,7 @@ concurrency:
2929
jobs:
3030
release:
3131
name: "Publish binaries for release"
32-
runs-on: macos-14
32+
runs-on: macos-15
3333

3434
steps:
3535
- name: "Checkout sources"

Sparkle/SUAppcastDriver.m

+4-1
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,10 @@ + (SUAppcastItem *)bestItemFromAppcastItems:(NSArray *)appcastItems getDeltaItem
434434
// Give the delegate a chance to provide a custom version comparator
435435
id<SPUUpdaterDelegate> updaterDelegate = _updaterDelegate;
436436
if ([updaterDelegate respondsToSelector:@selector((versionComparatorForUpdater:))]) {
437-
comparator = [updaterDelegate versionComparatorForUpdater:_updater];
437+
id updater = _updater;
438+
if (updater != nil) {
439+
comparator = [updaterDelegate versionComparatorForUpdater:updater];
440+
}
438441
}
439442
#pragma clang diagnostic pop
440443

0 commit comments

Comments
 (0)