Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accepting **kwargs in ModelLibrary.__init__ can hide typos. #182

Open
braingram opened this issue Aug 14, 2024 · 0 comments
Open

Accepting **kwargs in ModelLibrary.__init__ can hide typos. #182

braingram opened this issue Aug 14, 2024 · 0 comments

Comments

@braingram
Copy link
Collaborator

For example, making a library with ModelLibrary("my_asn.json", ondisk=True) does not create and "on disk" ModelLibrary since the argument was ondisk instead of on_disk.

One solution would be to split datamodels_open_kwargs as a separate keyword argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@braingram