Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of classmethod for _datamodels_open limits extensibility of Step #170

Open
braingram opened this issue Jul 23, 2024 · 0 comments
Open

Comments

@braingram
Copy link
Collaborator

During debugging memory usage with @tapastro we found the implementation of _datamodels_open as a class method to be both limiting and lead to confusion.

For example, it would have been useful to change _datamodels_open to only call datamodels.open when:

  • the input was not a DataModel
  • or the step was not part of a pipeline

However the second condition is impossible as _datamodels_open is a class method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant