Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove units from the ref files #490

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove units from the ref files #490

wants to merge 2 commits into from

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Oct 18, 2024 •
edited
Loading

Resolves RAD-nnnn

Closes #489

This PR removes the units from the reference files.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@WilliamJamieson WilliamJamieson mentioned this pull request Oct 18, 2024
Draft
5 tasks
@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.20%. Comparing base (810c17f) to head (a9a3080).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
+ Coverage   95.81%   97.20%   +1.39%     
==========================================
  Files           4        4              
  Lines         215      215              
==========================================
+ Hits          206      209       +3     
+ Misses          9        6       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly
Copy link
Collaborator

Thanks. This looks good. We're currently storing the units as an optional, unused bit of the schema like this:
https://github.com/spacetelescope/rad/blob/main/src/rad/resources/schemas/wfi_image-1.0.0.yaml#L105
so at least the information is in principle present in a machine readable way. Would you mind adding those bits?

I think that doesn't actually affect RTB's ability to build the files, though, so we could advertise these branches to RTB and they could develop the needed files?

@WilliamJamieson WilliamJamieson force-pushed the feature/remove_ref_units branch 2 times, most recently from d6b69b0 to fe6fc3d Compare October 18, 2024 17:56
@PaulHuwe PaulHuwe mentioned this pull request Oct 19, 2024
Open
@WilliamJamieson WilliamJamieson force-pushed the feature/remove_ref_units branch from a9a3080 to 871d5d3 Compare November 25, 2024 19:43
@PaulHuwe
Copy link
Collaborator

PaulHuwe commented Dec 6, 2024

This will also address #445 when implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dark Ref File Metadata
3 participants
@WilliamJamieson @schlafly @PaulHuwe