Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce technical debt of ATOCA/SOSS extraction code #8804

Closed
stscijgbot-jp opened this issue Sep 18, 2024 · 3 comments · Fixed by #9000
Closed

Reduce technical debt of ATOCA/SOSS extraction code #8804

stscijgbot-jp opened this issue Sep 18, 2024 · 3 comments · Fixed by #9000
Labels
Software Affected: extract_1d team-chartreuse technical-debt

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-3755 was created on JIRA by Tyler Pauly:

The implementation of the ATOCA algorithm for NIRISS SOSS spectral extraction was a large task, and many aspects of the project were left uncompleted. This ticket is being filed to address a variety of issues remaining with the code:

No unit tests
Lack of documentation
Stale code/TODOs abound
Some refactoring would likely improve performance and definitely improve readability
@emolter emolter mentioned this issue Dec 10, 2024
Merged
14 tasks
@stscijgbot-jp
Copy link
Collaborator Author

Comment by Ned Molter on JIRA:

Fixed by #9000 

@stscijgbot-jp
Copy link
Collaborator Author

Comment by David Law on JIRA:

Are you good with closing this now Tyler Pauly ?

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Tyler Pauly on JIRA:

I'm content to close this - PR was reviewed by NIS member and no large difference in outputs expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Software Affected: extract_1d team-chartreuse technical-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JP-3755: Remove unused options and add unit tests to SOSS extraction algorithm emolter/jwst
1 participant
@stscijgbot-jp