Skip to content

Commit bdf9fc5

Browse files
make jupyter_ui_poll a default dependency
1 parent 61694c3 commit bdf9fc5

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

jdaviz/async_utils.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
import logging
55
import threading
66

7+
from jupyter_ui_poll import ui_events
8+
79
from typing import Callable
810
import ipywidgets
911
from asyncio import Queue
@@ -131,13 +133,6 @@ def run_kernel_events_blocking_until(
131133
132134
Used to block in the notebook while we wait for a widget result.
133135
"""
134-
try:
135-
from jupyter_ui_poll import ui_events
136-
except ModuleNotFoundError:
137-
raise ModuleNotFoundError(
138-
"jupyter_ui_poll is not installed. Please install it with `pip install jupyter_ui_poll`"
139-
)
140-
141136
start_time = time.time()
142137
with ui_events() as poll:
143138
while condition():

jdaviz/configs/default/plugins/export/tests/test_export.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ async def mock_queue_screenshot_async(*args, **kwargs):
442442
export_plugin.export(overwrite=True)
443443

444444

445-
def test_figure_export(imviz_helper, ipython_kernel):
445+
async def test_figure_export(imviz_helper, ipython_kernel):
446446

447447
async def mock_queue_screenshot_async(*args, **kwargs):
448448
return b"test"

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ dependencies = [
4444
"s3fs>=2024.10.0",
4545
"joblib>=1.3.0",
4646
"ipyvuedraggable>=1.1.0",
47+
"jupyter_ui_poll>=1.1.0",
4748
]
4849
license-files = ["LICENSE.rst", "licenses/IPYFILECHOOSER_LICENSE.rst", "licenses/IMEXAM_LICENSE.txt", "licenses/GINGA_LICENSE.txt", "licenses/TEMPLATE_LICENCE.rst"]
4950
dynamic = [

0 commit comments

Comments
 (0)