Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total surface is submitted too early in simulation #247

Open
ehpor opened this issue Oct 1, 2024 · 0 comments
Open

Total surface is submitted too early in simulation #247

ehpor opened this issue Oct 1, 2024 · 0 comments
Labels
bug Something isn't working simulator

Comments

@ehpor
Copy link
Collaborator

ehpor commented Oct 1, 2024

Currently, the total surface of the DM is pushed to the data stream right after the submission of the event to the simulator. At that point in simulated time, the DM does not have that surface in the optical model. Submission to the total_surface should instead be done by the simulator upon handling that event. This is already done for motors, flip mounts and cameras.

This requires a change also in downstream simulators.

@ehpor ehpor added bug Something isn't working simulator labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working simulator
Projects
None yet
Development

No branches or pull requests

1 participant