Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename thorlabs_pm to thorlabs_power_meter #218

Open
ivalaginja opened this issue Jun 8, 2024 · 0 comments
Open

Rename thorlabs_pm to thorlabs_power_meter #218

ivalaginja opened this issue Jun 8, 2024 · 0 comments
Labels
low priority refactor Refactor existing code.

Comments

@ivalaginja
Copy link
Collaborator

This has been misleading in the past and would be nice to make clearer.

Rename script names, class names, for hardware and software services. Also don't forget the documentation page for this service, rename its file.

Test both in sim and hardware to make sure nothing broke. Make pair-PR in hicat-package2 to update service config.

@ivalaginja ivalaginja added low priority refactor Refactor existing code. labels Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority refactor Refactor existing code.
Projects
None yet
Development

No branches or pull requests

1 participant