Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyCDN support [FR] #197

Open
shoored opened this issue Jan 24, 2023 · 2 comments
Open

KeyCDN support [FR] #197

shoored opened this issue Jan 24, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@shoored
Copy link

shoored commented Jan 24, 2023

Hey André,

In addition to my Imagekit FR, I would like to make another request ;)

KeyCDN has an Image Processing service that looks quite nice and as far as I can tell has similar functionality / API as imgix. Might be an even better alternative for the recently costly imgix.

Not sure how difficult it would be to add support though.

https://www.keycdn.com/support/image-processing

Cheers!

@aelvan aelvan added the enhancement New feature or request label Jan 29, 2023
@shoored
Copy link
Author

shoored commented Mar 31, 2023

Hey @aelvan, I've been trying to get a custom transformer going myself. It really ain't for the faint hearted ;) But I think I understand the base flow. I'm currently trying to map the Imager parameters to those of KeyCDN.

I think this transformer would be a welcoming switch for a lot of imgix users because of their latest price changes.

What would be a good way to tackle this in your opinion?

  • I create a free Craft 4 custom transformer plugin and place it in the plugin store
  • I do the first steps and give you access to the repo so you can do code review or even code the last parts and launch it under the Space Cat Ninja umbrella
  • Something completely different
  • Stop bugging me

Note: I'm not a PHP programmer by day so there's probably things that need some improvements.

@aelvan
Copy link
Contributor

aelvan commented Apr 2, 2023

Hi,

Great that you jumped into the deep end yourself. ;)

If you want to put it in the plugin store (free or paid) yourself, and provide a first line of support, that would be the best for me. I'll be available to assist if you need any help, and if you want to get rid of it at some point, I can take over.

If you put it up on a repo when you have something working, I can do a code review and let you know if there's something I think should be solved differently. Note that there's transformerConfig config setting that can be used to pass custom config parameters to the transformer, and transformerParams which can be used to pass transform parameters directly to the transformer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants