Add docker support

[0phoff]

It would be nice to add support for docker containers, in the same way you have the ssh working..
Check if the current command is docker/nvidia-docker run, and get the container-name if that is the case!

I might take a stab at implementing it myself. I'll submit a pr if I'm successful!

[soyuka]

I might take a stab at implementing it myself. I'll submit a pr if I'm successful!

Feel free to do so 👍 I'm not using docker that much 😀

[0phoff]

haha no problem! I just created this issue in the hope someone would create it for me 😝

[0phoff]

OK, I tried to implement it, and I have a crude version working here.

I say crude, because there are a few problems that I could not solve:

1. The script only works if you specify a container name in your command with the --name flag. I have no clue how to work without this. The problem here is that the command uses a docker daemon to actually start the container. This means that the PID from the docker run command is not related to the PID from the actual docker container. I looked at all the info from pgrep but could not find any link between the processes.
2. The script will only display the correct user if it was set using the -u, --user flag. The reason for this is that I use the docker inspect command to get the host and user, and this command only works if you set the user this way (and thus will not work if you change user inside of the docker container with su). I think this problem might be solveable by using nsenter to switch namespaces and then using some shell dark magic to find out what user has a tty-session opened. But this sadly goes over my head...

I also 'enhanced/improved/...' the script so that it will now also work when an ssh/docker command was ran from a subprocess. Not too sure if it is useful for ssh, but I tend to run my docker containers from shell scripts, so I dont have to remember and retype all the flags I need!

I dont feel like my changes merit a pull request, but I felt like posting my progress here, so that someone that feels competent enough to fix my problems tackle this problem, knows that some things have already been done! 🤡

In the meanwhile, I'll just use my fork, as it works for me (I tend to always name containers I frequently use, and dont really use other users except for the main root one...)