[Optimization] R0_and_mean_shape_estimation.R - Special-case zero length data

[Siddhant]

Covid19/R0_and_mean_shape_estimation.R

Line 56 in a4fe601

for(j in 1:N){

We can skip this loop for States/UT who (thankfully) have no cases, or date range having no cases. No need of unnecessarily doing N^2 iterations.

Consider directly returning 'NA' values for R0, maybe?

[sourish-cmi]

Yes ... N^2 is a big headache... for some choices of mean and shape it is returning NA. Thinking of binary search but not sure

…

On Mon, 13 Apr 2020, 11:40 Siddhant Saraf, ***@***.***> wrote: https://github.com/sourish-cmi/Covid19/blob/a4fe6010b18872d65b51c1c17ba99914dba61240/R0_and_mean_shape_estimation.R#L56 We can skip this loop for States/UT who (thankfully) have no cases. No need of unnecessarily doing N^2 iterations. Consider directly returning 'NA' values for R0, maybe? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANOBFYQDNY4U4UYGMCISI2TRMKUDNANCNFSM4MGXXXTQ> .

[sourish-cmi]

Agree ... a check will work

…

On Mon, 13 Apr 2020, 11:40 Siddhant Saraf, ***@***.***> wrote: https://github.com/sourish-cmi/Covid19/blob/a4fe6010b18872d65b51c1c17ba99914dba61240/R0_and_mean_shape_estimation.R#L56 We can skip this loop for States/UT who (thankfully) have no cases. No need of unnecessarily doing N^2 iterations. Consider directly returning 'NA' values for R0, maybe? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANOBFYQDNY4U4UYGMCISI2TRMKUDNANCNFSM4MGXXXTQ> .