Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent spoiler app from generating links too long to be pasted in chat #172

Open
wimglenn opened this issue Jan 18, 2018 · 5 comments
Open

Comments

@wimglenn
Copy link
Contributor

Preferably, integrate a hastebin or similar (so the link can be short no matter the paste length).

@davidism
Copy link
Member

davidism commented Jan 18, 2018

I didn't do short links to avoid storing the data in the database and to avoid very long spoilers. Do you know what the length limit of chat messages is?

@wimglenn
Copy link
Contributor Author

500 chars

@davidism
Copy link
Member

davidism commented Jan 18, 2018

I can at least put an error message in if the encoded data and default message exceeds that.

@wimglenn
Copy link
Contributor Author

Well, that would be better than nothing. Can probably find a better encoding than base64 without too much effort.

@davidism
Copy link
Member

qntm did some work on that: https://qntm.org/twitcodings, although I don't think most other encodings are URL safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants