You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After the build src/sonic-frr/frr looks changed. This is cosmetic only, because a rebuild resets the submodule. But it's a small annoyance that we can fix.
==== Why I did it
After a build ./src/sonic-frr/frr was always marked as "modified". This
changeset resets it to the way it was before the build.
Issue: sonic-net#20869
==== How I did it
The sonic-frr/Makefile had steps to apply stg (and other) patches. Now a
checkout to the original branch is done at the end, and other cleanup is
done at the start.
==== How to verify it
Run:
make configure PLATFORM=broadcom
make BLDENV=bookworm -f Makefile.work \
target/debs/bookworm/frr_8.5.4-sonic-0_amd64.deb
Observe how ./src/sonic-frr/frr is unchanged afterwards. The patched
version is still available in a stored stg_temp branch.
wdoekes
added a commit
to ossobv/sonic-buildimage
that referenced
this issue
Nov 20, 2024
==== Why I did it
After a build ./src/sonic-frr/frr was always marked as "modified". This
changeset resets it to the way it was before the build.
Resolves: sonic-net#20869
==== How I did it
The sonic-frr/Makefile had steps to apply stg (and other) patches. Now a
checkout to the original branch is done at the end, and other cleanup is
done at the start.
==== How to verify it
Run:
make configure PLATFORM=broadcom
make BLDENV=bookworm -f Makefile.work \
target/debs/bookworm/frr_8.5.4-sonic-0_amd64.deb
Observe how ./src/sonic-frr/frr is unchanged afterwards. The patched
version is still available in a stored stg_temp branch.
Description
After the build
src/sonic-frr/frr
looks changed. This is cosmetic only, because a rebuild resets the submodule. But it's a small annoyance that we can fix.Steps to reproduce the issue:
Describe the results you received:
Describe the results you expected:
Fix
See this PR: #20868.
The text was updated successfully, but these errors were encountered: