Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

De-integrate payment methods? #283

Open
mamhoff opened this issue Nov 12, 2020 · 2 comments
Open

De-integrate payment methods? #283

mamhoff opened this issue Nov 12, 2020 · 2 comments

Comments

@mamhoff
Copy link
Contributor

mamhoff commented Nov 12, 2020

Solidus has a concept of Payment methods such as "CreditCard", "PayPal" and so on. This gem uses a single payment method for all of these, adding quite bit of complexity to e.g. the payment form when a store has more than just Braintree as a provider. Would you be open for a pull request that creates a Solidus payment method per payment method? So one could imagine instead of having just SolidusPaypalBraintree::Gateway the following three classes:

  • SolidusPaypalBraintree::CreditCard
  • SolidusPaypalBraintree::ApplePay
  • SolidusPaypalBraintree::Paypal

We have patched the gem in one of our projects to provide this. It makes analytics on an SQL level easier as well...

@seand7565
Copy link
Contributor

I love this idea! Definitely would like to see this happen. I have never liked that this extension has an admin tab for overall setup, I could see that being unnecessary if we provided different payment classes.

@stale
Copy link

stale bot commented Nov 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 11, 2022
@gsmendoza gsmendoza removed the wontfix label Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants