Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add treeshaking, improve CI #1750

Merged
merged 4 commits into from
Feb 10, 2025
Merged

test: add treeshaking, improve CI #1750

merged 4 commits into from
Feb 10, 2025
+1,307 −574

Conversation

atilafassina
Copy link
Member

@atilafassina atilafassina commented Jan 31, 2025 •
edited
Loading

  • test: add treeshaking test
  • infra: move tests inside workspaces and add unit to CI

closes #1751

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7f53a99

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "server-function-test" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@netlify Netlify
Copy link

netlify bot commented Jan 31, 2025 •
edited
Loading

✅ Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 7f53a99
🔍 Latest deploy log https://app.netlify.com/sites/solid-start-landing-page/deploys/67a8f72f11c95f0008bd7de7
😎 Deploy Preview https://deploy-preview-1750--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 31, 2025 •
edited
Loading

Open in Stackblitz

More templates

npm i https://pkg.pr.new/@solidjs/start@1750

commit: 7f53a99

@atilafassina atilafassina force-pushed the tests/treeshake branch 6 times, most recently from 036a408 to e21b5c1 Compare January 31, 2025 20:50
@atilafassina atilafassina marked this pull request as ready for review February 1, 2025 18:29
birkskyum
birkskyum reviewed Feb 3, 2025
View reviewed changes
Copy link
Member

@birkskyum birkskyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all the screenshots needed?

@atilafassina atilafassina force-pushed the tests/treeshake branch 2 times, most recently from d3619ac to 1c57441 Compare February 7, 2025 15:52
github-actions[bot]
github-actions bot reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@atilafassina atilafassina changed the title tests: add treeshaking, improve CI test: add treeshaking, improve CI Feb 7, 2025
@birkskyum birkskyum merged commit 05e6b37 into main Feb 10, 2025
10 checks passed
@birkskyum birkskyum deleted the tests/treeshake branch February 10, 2025 08:56
@birkskyum birkskyum mentioned this pull request Feb 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot]

@birkskyum birkskyum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Vitest to /tests workspace
2 participants
@atilafassina @birkskyum