Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[audio] the playing signal should be changed to false when audio.state is not PLAYING #732

Open
chenzhiwei opened this issue Jan 6, 2025 · 0 comments

Comments

@chenzhiwei
Copy link

Describe the bug

When the audio completes, the playing() signal is still true, so can't use the play button to trigger play again.

The playing signal defined here:
https://github.com/solidjs-community/solid-primitives/blob/82245cf/packages/audio/dev/index.tsx#L70

The setPlaying will always set the playing to true, so it does not trigger play again:
https://github.com/solidjs-community/solid-primitives/blob/82245cf/packages/audio/dev/index.tsx#L81

Minimal Reproduction Link

https://github.com/solidjs-community/solid-primitives/blob/main/packages/audio/dev/index.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant