Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate adding --features bpf-entrypoint to platform tools #15

Open
buffalojoec opened this issue Mar 9, 2024 · 0 comments
Open
Assignees

Comments

@buffalojoec
Copy link
Contributor

Problem

We've decided to do away with the no-entrypoint feature for BPF programs, where you'd typically import another BPF program's crate by specifying { .., features = ["no-entrypoint"] }.

Instead, entrypoint will be disabled by default, and a new feature bpf-entrypoint will be the flag that enables the program's entrypoint.

This is much better developer experience for those who wish to work with program crates in their dependencies, as well as a more proper use of Rust program features - namely, the fact that features should be additive.

The issue we have now is that we have to remember to provide --features bpf-entrypoint whenever we build and invoke a program. At a minimum, that means cargo build-sbf --features bpf-entrypoint and cargo test-sbf --features bpf-entrypoint.

Solution

Consider adding this feature to the platform tools so that developers need not remember to provide this feature flag.

Imagine deploying to mainnet with no program entrypoint!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant