Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lot of dApps does not provide name and icon #428

Open
kackogut opened this issue Apr 11, 2023 · 3 comments
Open

Lot of dApps does not provide name and icon #428

kackogut opened this issue Apr 11, 2023 · 3 comments

Comments

@kackogut
Copy link

Since mIconUri and mIdentityName fields are @Nullable a lot of dApps does not provide them or provide them only for the first authorize request. Some examples:

A good example of what Wallets might expect is https://orca.so/ which always provide both of those fields for all requests.

@Michaelsulistio
Copy link
Contributor

Michaelsulistio commented Apr 20, 2023

For Mobile dApps that have this issue, look at the Authorize and Reauthorize of these dApp integration guides:

For Web dApps that have this issue with mobile wallet apps, look at the Advanced Usage section.

You'll need to provide the App Identity metadata of identityName, iconUri, and identityUri. This way users will be able to recognize your dApp during the transaction signing/sending flow.

@Michaelsulistio
Copy link
Contributor

Michaelsulistio commented Apr 20, 2023

Current status for each Web dApp.
Repro:

  • Open dApp URL in mobile browser
  • Connect Wallet with Mobile Wallet Adapter
  • Choose Solflare wallet
  • See missing App Identity metadata

Some wallets like Solflare, do some caching/verification on their end to fill in missing app icons, but wallets like Phantom do not do this, and solely rely on the metadata passed in from App Identity.

Web App flow:

Orca (✅) Mango Tensor Magic Eden Marinade Finance
Screenshot_20230420-092538 Screenshot_20230420-092354 Screenshot_20230420-092507 Screenshot_20230420-092425 Screenshot_20230420-093411

@safaiyeh
Copy link

safaiyeh commented Apr 21, 2023

+1 on requiring these fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants