Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue with max limit not increasing after GitHub connection #28

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

rahulbarmann
Copy link
Contributor

Fix: Airdrop Limit Not Increasing After GitHub Connection

Description

This PR addresses an issue where connecting a GitHub account did not increase the maximum airdrop limit as expected. The system initially sets the limit at 5 SOL, and although users are informed that connecting their GitHub account unlocks a higher limit, the actual limit remains unchanged.

Changes Implemented

  • Updated the front end to reflect the increased airdrop limit dynamically.

Before and After Screenshots

Before Fix

  • Without GitHub Connection (Limit: 5 SOL):

    Without GitHub Connection

  • With GitHub Connection (Limit Still: 5 SOL):

    With GitHub Connection

After Fix

  • Without GitHub Connection (Limit: 5 SOL):

    Post-Fix Without GitHub Connection

  • With GitHub Connection (Limit: Increased to 10 SOL):

    Post-Fix With GitHub Connection

Testing

  • Verified that the limit remains 5 SOL for users without a connected GitHub account.
  • Tested the flow of connecting a GitHub account and observed the limit increase to the expected value.

Issue Reference

Resolves #27

Checklist

  • Updates frontend to reflect the correct limit.
  • Includes testing and validation for the fix.

Additional Notes

If there are further improvements or suggestions, I am open to making adjustments. Thank you for reviewing this PR!

Copy link

vercel bot commented Jan 3, 2025

@rahulbarmann is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@Woody4618
Copy link
Collaborator

Thank you, looks good. At the moment the faucet is heavily botted. I want to first try reduce that before increasing the limits even more. If you have ideas on how to decrease botting would be great to get help on that.

@Woody4618
Copy link
Collaborator

I increased the time between airdrops to 8 for now so i think your change is good to go in. Thanks again

@Woody4618 Woody4618 merged commit 4ad76c0 into solana-developers:main Jan 3, 2025
1 check failed
@rahulbarmann
Copy link
Contributor Author

Happy to help :)
And as for the extreme botting problem, I think stricter IP rate-limiting might help. Increasing the cooldown duration for the airdrop is also fine for now.

Let me know if I can help you with anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airdrop Limit Not Increasing After Connecting GitHub
2 participants