-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engine.io 6.6.3 syntax error issue with downstream cookie package in latest update - Gulp/Npm/Node JS compiler. #5283
Comments
One more issue with 6.6.3 - it is pulling in cookie@~1.0.2, which requires node version >= 18, this is breaking for all environment under 18. |
I'm getting these same errors, I currently cannot upgrade node, and now I cannot run my karma tests, as they depend on socket.io which is broken because of this issue, |
Also seeing this issue, and the only way we can get beyond it to use BrowserSync is to run: |
This reverts commit 7427109. The new version of the `cookie` package contains code with optional chaining (`?.`), which is not supported by older Node.js versions (< 14). The types for cookie are now bundled, so that there is no conflict with the types coming from `cookie@1`: > error TS2724: '"cookie"' has no exported member named 'CookieSerializeOptions'. Did you mean 'SerializeOptions'? > > import type { CookieSerializeOptions } from "cookie"; > ~~~~~~~~~~~~~~~~~~~~~~ Related: #5283
Could you please check? |
Yes, issue fixed now. Thank! |
I confirm, issue fixed now! |
Great, thanks for the heads-up 👍 |
Describe the bug
When running Gulp with browsersync, the latest build of engine.io throws the following errors that appear in the downstream cookie dependency:
To Reproduce
Run a node JS instance using gulp with latest version of engine.io. Reverting back to 6.6.2 resolves the issue completely.
Socket.IO server version:
4.8.1
Engine.IO dependency version:
6.6.3
Expected behavior
Successful build completion using gulp, NPM, Node JS
Gulp:
4.0
Node:
20.22
NPM:
10
Platform:
The text was updated successfully, but these errors were encountered: