We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When I reviewed the code, the code here:
socket.io-redis-adapter/lib/index.ts
Lines 527 to 533 in ef5f0da
If requestId does not exist in this.requests, but requestId exists in this.ackRequests, the code will continue to execute:
requestId
this.requests
this.ackRequests
Line 537 in ef5f0da
I'm wondering if there is a problem with this business logic? If there is no problem, is this.ackRequests.has(requestId) a redundant condition?
this.ackRequests.has(requestId)
The text was updated successfully, but these errors were encountered:
No branches or pull requests
When I reviewed the code, the code here:
socket.io-redis-adapter/lib/index.ts
Lines 527 to 533 in ef5f0da
If
requestId
does not exist inthis.requests
, butrequestId
exists inthis.ackRequests
, the code will continue to execute:socket.io-redis-adapter/lib/index.ts
Line 537 in ef5f0da
I'm wondering if there is a problem with this business logic? If there is no problem, is
this.ackRequests.has(requestId)
a redundant condition?The text was updated successfully, but these errors were encountered: