Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V3 protocol test suite #30

Open
sleeyax opened this issue Jun 19, 2023 · 2 comments
Open

Add V3 protocol test suite #30

sleeyax opened this issue Jun 19, 2023 · 2 comments

Comments

@sleeyax
Copy link

sleeyax commented Jun 19, 2023

Would it be possible to add a test-suite for the V3 protocol? I'm adding support for the V3 protocol to socketioxide (an implementation in Rust) and it would definitely help to test the correctness of the implementation without too much guesswork or possible oversight.

@darrachequesne
Copy link
Member

Sure, I'll add a test suite for v3 👍

@sleeyax
Copy link
Author

sleeyax commented Jun 28, 2023

If no one has started working on this issue yet, I'd be willing to bootstrap a basic test suite for engine.io V3 protocol and create a PR. It might not cover everything yet as I'm quite new to the protocol and wasn't involved in prior development myself. But it's a start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants