Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several improvements and bug fixes across multiple files. The most important changes include enabling Deno in the VSCode settings, updating the changelog with a new release, fixing a bug in the WebSocket transport, and enhancing compatibility in the msgpack library.
Configuration Updates:
.vscode/settings.json
: Enabled Deno by setting"deno.enable": true
.Documentation Updates:
CHANGELOG.md
: Added release notes for version 0.2.1, including a bug fix for the engine.Bug Fixes:
packages/engine.io/lib/transports/websocket.ts
: Added a check forreadyState
before sending packets in the WebSocket transport.Compatibility Enhancements:
packages/msgpack/lib/decode.ts
: Modified the_buffer
type to acceptArrayBuffer
orSharedArrayBuffer
.packages/msgpack/lib/encode.ts
: Updated the_bin
type to acceptArrayBuffer
orArrayBufferLike
and changedkeys
to be of typeany[]
. [1] [2]Code Cleanup:
packages/socket.io/lib/parent-namespace.ts
: Removed commented-out adapter code from theParentNamespace
class.packages/socket.io/lib/server.ts
: EnsuredServerReservedEvents
interface types extendEventsMap
.Fixes Issue