Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readyState bug while sending data from server #23

Open
itsfuad opened this issue Aug 29, 2024 · 0 comments · May be fixed by #22
Open

readyState bug while sending data from server #23

itsfuad opened this issue Aug 29, 2024 · 0 comments · May be fixed by #22

Comments

@itsfuad
Copy link

itsfuad commented Aug 29, 2024

Current implementation of socketio doesn't have if (this.writable && this.readyState === "open") check before sending the data. This causes server crash.

Screenshot 2024-08-27 192747

Because the code was on the Render cloud, I did not found any way to reproduce it on my pc. Thus by adding this.readyState === "open" check, the issue was fixed.

I pulled a request with the fix.
@itsfuad itsfuad linked a pull request Nov 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug fix for program crash itsfuad/socket.io-deno
1 participant
@itsfuad