Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Why not Vue 3? #17

Open
AnoRebel opened this issue Jun 10, 2021 · 5 comments
Open

[Question] Why not Vue 3? #17

AnoRebel opened this issue Jun 10, 2021 · 5 comments
Labels
question Further information is requested

Comments

@AnoRebel
Copy link

AnoRebel commented Jun 10, 2021

As the heading suggests, this is more of a question than an issue.

Why not use vue 3?
Is it because of Vuetify(since it doesnt have a vue 3 integration yet)?

@darrachequesne
Copy link
Member

That's a fair question, thanks! I think we mainly focused on Getting Things Done™, instead of checking whether all the dependencies (vuetify, chartjs) would work with Vue 3.

But we could totally migrate to Vue 3 in the future 👍

@darrachequesne darrachequesne added the question Further information is requested label Jun 11, 2021
@AnoRebel
Copy link
Author

AnoRebel commented Jun 12, 2021

Oh, ok, cool then..
When I get time, I was thinking of creating the Vue 3 version from your code(refactor it basically).
Would that be okay?
I'll make a branch and a PR later after.
Cant guarantee when though.

Also, I think with all the libraries used, only vuetify lacks Vue 3 support, so i'll probably use something like tailwindcss instead.

@darrachequesne
Copy link
Member

@AnoRebel that would be awesome 👍

@AnoRebel
Copy link
Author

Sorry it took I while, I was kinda busy..
So the 1st iteration is at my fork on the next branch. Its not complete yet but most of it is complete. If anyone has time to test and point out stuff I missed or thats not working, would be great.

@davidzwa
Copy link

davidzwa commented Aug 7, 2022

Just FYI: Vuetify3 is not getting released soon. We have to hold our breath for months, if it continues like this with Vuetify 3 😉
Also note that Vuetify v3.1 will take even longer and only that version is feature-complete (VDataTable or VSchedule anyone?)
Once it is released, I can aid in the conversion as I maintain an app in Vuetify 3 beta as well as Vuetify 2.

This UI does not use Typescript (sadly), no vee-validate (luckily) and also not vue-class-components (luckily). That will save you lots of migration efforts!
I suggest changing to Typescript and changing Vuex to Pinia. It's been really nice in Pinia so far!

My Vue2 + Vuetify2 project: https://github.com/fdm-monster/fdm-monster/tree/develop/client-vue
The Vue3 + Vuetify3 + Vite project with VeeValidate, Zod and Pinia: https://github.com/fdm-monster/fdm-monster-client

You can ping me here for questions, if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants