Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logout feature #12

Open
hasan-4 opened this issue Jun 5, 2021 · 9 comments
Open

logout feature #12

hasan-4 opened this issue Jun 5, 2021 · 9 comments
Labels
enhancement New feature or request

Comments

@hasan-4
Copy link
Contributor

hasan-4 commented Jun 5, 2021

add logout feature which will clear the browser local storage



Thank you

@hasan-4
Copy link
Contributor Author

hasan-4 commented Jun 5, 2021

add this code with logout button

localStorage.clear(); // it will clear the  browser local storage data only

@fahadpf
Copy link

fahadpf commented Jun 7, 2021

I would not suggest clearing the whole localStorage. I'm using this project on a subdirectory of my domain, and I also have some very important data stored in localStorage.

It would be better if we clear only those keys which are set by Admin UI.

@hasan-4
Copy link
Contributor Author

hasan-4 commented Jun 7, 2021

@fahadpf
i agree with you

Replay: @mdawaffe

I would not suggest clearing the whole localStorage. I'm using this project on a subdirectory of my domain, and I also have some very important data stored in localStorage.

It would be better if we clear only those keys which are set by Admin UI.

@darrachequesne
Copy link
Member

That's a good idea. @imithu would you have the time to implement it?

@darrachequesne darrachequesne added the enhancement New feature or request label Jun 8, 2021
@hasan-4
Copy link
Contributor Author

hasan-4 commented Jun 8, 2021

sure, i will do it in nuxt

Replay: @darrachequesne
That's a good idea. @imithu would you have the time to implement it?

@Thomas-1985
Copy link

It would be really great if this could be implemented

@darrachequesne
Copy link
Member

@Thomas-1985 could you please explain your use case?

I'm not sure about the feature that is requested here. Should we overload the "update" button?

@Thomas-1985
Copy link

Well there should be a "logout" button that logs you out of the ui. Like @fahadpf mentioned, the code should only clear the set localStorage keys and not clear it out completely (there could be other data stored).

@tfrancois
Copy link

This excellent piece of software is sorely lacking this feature - it would make this product almost PERFECT. Please implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants