fix: only collate configured services #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmars
force-pushed
the
fix/only-scrape-collate-configured
branch
2 times, most recently
from
df9f250 to
4db55db
Compare
If a service is removed from configuration, stop collating it.
cmars
force-pushed
the
fix/only-scrape-collate-configured
branch
from
4db55db to
dc86458
Compare
|
Superseded by #216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a service is removed from configuration, stop collating it. Storage is left intact.
This fixes an issue where past service scrapes continue to show up in the collated output, even when removed from the services configuration.
The same result might be had by removing a service from config and manually deleting items from storage on deploy, but this is not a very desirable thing to do in production. It's akin to a stop-the-world manual database migration.
Stacked on #210
Fixes #209