Merge pull request #290 from snyk/fix/log-scrape-errors

love-bhardwaj · web-flow · commit 4c6fcc38496d · 2023-04-20T19:48:24.000-04:00
fix: log scrape errors for services
diff --git a/vervet-underground/internal/scraper/scraper.go b/vervet-underground/internal/scraper/scraper.go
@@ -125,6 +125,7 @@ func (s *Scraper) Run(ctx context.Context) error {
 			err := s.scrape(ctx, scrapeTime, svc)
 			if err != nil {
 				metrics.scrapeError.WithLabelValues(svc.base).Inc()
+				log.Error().Str("service", svc.name).Err(err).Msg("error scraping service")
 			}
 			log.Debug().Str("service", svc.name).Msg("finished scrape")
 			errCh <- err

Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,7 @@ func (s *Scraper) Run(ctx context.Context) error {`
`125`	`125`	`err := s.scrape(ctx, scrapeTime, svc)`
`126`	`126`	`if err != nil {`
`127`	`127`	`metrics.scrapeError.WithLabelValues(svc.base).Inc()`
	`128`	`+ log.Error().Str("service", svc.name).Err(err).Msg("error scraping service")`
`128`	`129`	`}`
`129`	`130`	`log.Debug().Str("service", svc.name).Msg("finished scrape")`
`130`	`131`	`errCh <- err`