Skip to content

Commit

Permalink
fix: update golangci-lint
Browse files Browse the repository at this point in the history
The version used in CI has issues with go 1.22 which prevents building
this app.

ifshort is fully inactivated in this version so will error if it is
enabled.
  • Loading branch information
jgresty committed Aug 1, 2024
1 parent 86046a2 commit 0a9e147
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:

lint:
docker:
- image: golangci/golangci-lint:v1.51.0
- image: golangci/golangci-lint:v1.59.1
steps:
- checkout
- run:
Expand Down
1 change: 0 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ linters:
- gocyclo
# - gosec - Good to have linter but potential to introduce breaking changes.
# - forbidigo - Good to have linter but potential to introduce breaking changes.
- ifshort
- lll
- misspell
- nakedret
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ GO_BIN=$(shell pwd)/.bin/go

SHELL:=env PATH=$(GO_BIN):$(PATH) $(SHELL)

GOCI_LINT_V?=v1.54.2
GOCI_LINT_V?=v1.59.1

.PHONY: all
all: lint test build
Expand Down

0 comments on commit 0a9e147

Please sign in to comment.