Merge pull request #532 from snyk/feat/IDE-141_flip-feature-flag-for-snyk-code-via-ls

feat: flip feature flag for Snyk Code via LS to true [IDE-141]

Author: ShawkyZ

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Snyk Security Changelog
 
+## [2.8.0]
+
+### Added
+- Serve Snyk Code functionality via language server. This enables auto-scanning on startup / save, code actions for Snyk Learn and, if enabled, Snyk Auto-Fix. The number of uploaded files is not shown anymore. 
+
 ## [2.7.21]
 
 ### Fixed

src/main/kotlin/io/snyk/plugin/Utils.kt

@@ -278,7 +278,7 @@ fun isContainerEnabled(): Boolean = true
 
 fun isFileListenerEnabled(): Boolean = pluginSettings().fileListenerEnabled
 
-fun isSnykCodeLSEnabled(): Boolean = Registry.`is`("snyk.preview.snyk.code.ls.enabled", true)
+fun isSnykCodeLSEnabled() = true
 
 fun isSnykOSSLSEnabled(): Boolean = Registry.`is`("snyk.preview.snyk.oss.ls.enabled", false)
 

src/main/kotlin/io/snyk/plugin/ui/settings/ScanTypesPanel.kt

@@ -269,7 +269,7 @@ class ScanTypesPanel(
 
     private fun getUploadingFilesMessage(): String {
         // FIXME: implement count of files
-        if (isSnykCodeLSEnabled()) return "Snyk Code Language Server is enabled. Count of files is not implemented yet."
+        if (isSnykCodeLSEnabled()) return ""
         val allSupportedFilesInProject =
             SnykCodeUtils.instance.getAllSupportedFilesInProject(project, true, null)
         val allSupportedFilesCount = allSupportedFilesInProject.size

src/test/kotlin/io/snyk/plugin/core/IgnoreInfoHolderPlatformTestCase.kt

@@ -162,20 +162,6 @@ class SnykTaskQueueServiceTest : LightPlatformTestCase() {
         snykTaskQueueService.downloadLatestRelease()
     }
 
-    fun testSastEnablementCheckInScan() {
-        val snykTaskQueueService = project.service<SnykTaskQueueService>()
-        val settings = pluginSettings()
-        settings.ossScanEnable = false
-        settings.snykCodeSecurityIssuesScanEnable = true
-        settings.snykCodeQualityIssuesScanEnable = true
-        settings.token = "testToken"
-
-        snykTaskQueueService.scan(false)
-        PlatformTestUtil.dispatchAllInvocationEventsInIdeEventQueue()
-
-        verify { snykApiServiceMock.getSastSettings() }
-    }
-
     fun `test LCE should be unknown in initial settings state`() {
         val settings = pluginSettings()
 
@@ -234,45 +220,6 @@ class SnykTaskQueueServiceTest : LightPlatformTestCase() {
         }
     }
 
-    fun testSnykTaskQueueServiceScanCodeOnStartupAndFailsWhenLS() {
-        val registryValue = Registry.get("snyk.preview.snyk.code.ls.enabled")
-        registryValue.setValue(false)
-
-        val snykTaskQueueService = project.service<SnykTaskQueueService>()
-        val settings = pluginSettings()
-        settings.ossScanEnable = true
-        settings.snykCodeSecurityIssuesScanEnable = true
-        settings.snykCodeQualityIssuesScanEnable = true
-        settings.token = "testToken"
-        settings.iacScanEnabled = true
-        settings.containerScanEnabled = true
-        getSnykCachedResults(project)?.currentOssResults = null
-        getSnykCachedResults(project)?.currentIacResult = null
-        getSnykCachedResults(project)?.currentContainerResult = null
-        getSnykCachedResults(project)?.currentSnykCodeResults = null
-
-        val fakeOSSResult = OssResult(emptyList())
-        val fakeIacResult = IacResult(emptyList())
-        val fakeContainerResult = ContainerResult(emptyList())
-
-        mockkStatic("io.snyk.plugin.UtilsKt")
-        every { isIacEnabled() } returns true
-        every { isCliInstalled() } returns true
-        every { getSnykCode(project)?.scan() } returns null
-        every { getOssService(project)?.scan() } returns fakeOSSResult
-        every { getIacService(project)?.scan() } returns fakeIacResult
-        every { getContainerService(project)?.scan() } returns fakeContainerResult
-
-        snykTaskQueueService.scan(true)
-        PlatformTestUtil.dispatchAllInvocationEventsInIdeEventQueue()
-
-        assertEquals(fakeOSSResult, getSnykCachedResults(project)?.currentOssResults)
-        assertEquals(fakeIacResult, getSnykCachedResults(project)?.currentIacResult)
-        await().atMost(2, TimeUnit.SECONDS).until {
-            getSnykCachedResults(project)?.currentContainerResult != null
-        }
-        verify(exactly = 1) { getSnykCode(project)?.scan() }
-    }
     fun testSnykTaskQueueServiceDoesNotScanCodeOnStartupWhenLS() {
         val registryValue = Registry.get("snyk.preview.snyk.code.ls.enabled")
         registryValue.setValue(true)

src/test/kotlin/io/snyk/plugin/services/SnykTaskQueueServiceTest.kt

@@ -103,17 +103,6 @@ class SnykCodeAnnotatorTest : BasePlatformTestCase() {
         assertTrue(actual.contains(issue.title) || actual.contains(issue.message))
     }
 
-    @Test
-    fun `test apply should trigger newAnnotation call`() {
-        mockkObject(AnalysisData)
-        every { AnalysisData.instance.getAnalysis(SnykFile(psiFile.project, psiFile.virtualFile)) } returns
-            createSnykCodeResultWithIssues()
-
-        cut.apply(psiFile, Unit, annotationHolderMock)
-
-        verify { annotationHolderMock.newAnnotation(any(), any()) }
-    }
-
     @Test
     fun `test apply for disabled Severity should not trigger newAnnotation call`() {
         mockkObject(AnalysisData)