Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Repository organization not updated when topics changed in snyk-orgs.yaml #41

Open
ebickle opened this issue Jan 24, 2022 · 0 comments
Open

Comments

@ebickle
Copy link

ebickle commented Jan 24, 2022

When there is already a cached list of repositories and the list of topics in snyk-orgs.yaml is changed in a manner that causes a repository to be mapped to a new Snyk organization, no change is made.

  • sync.py(107) if self.has_repo(repo.id): returns true
  • sync.py(111) if existing_repo.is_older(repo.updated_at): returns false
  • The add_repo function then returns without making any change. The old snyk organization is left in place, even though it changed.

The "is_older" if statement should probably contain an additional check to see if the org_name changed as well. Also note that snyk.py(125) may have a bug as well - if the repository changes back to the default that code will be skipped.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant