Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer displayed in the documentation #11

Open
MattMonk opened this issue Sep 14, 2024 · 1 comment
Open

No longer displayed in the documentation #11

MattMonk opened this issue Sep 14, 2024 · 1 comment
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@MattMonk
Copy link
Collaborator

The plugin is absent from the plugin catalog page: https://snakemake.github.io/snakemake-plugin-catalog/index.html

Can see there is an error in the nightly github action e.g.:
https://github.com/snakemake/snakemake-plugin-catalog/actions/runs/10859663450/job/30139296545#step:5:68

@MattMonk MattMonk added bug Something isn't working documentation Improvements or additions to documentation labels Sep 14, 2024
@MattMonk
Copy link
Collaborator Author

Tracked this down to a problem with the settings, specifically the url_decorator setting.

The automatic documentation extracts info about the settings here: https://github.com/snakemake/snakemake-plugin-catalog/blob/main/source/collect_plugins.py#L87

However, the default value of url_decorator is a lambda function. So when it attempts to serialise this (json.dumps) it causes an error.

Could fix this by opening a pull request to snakemake-plugin-catalog to support lambda functions by saving the source of the lambda function with inspect.getsourcelines() which would then be a serialisable string instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant