Proposed change: allow irods_environment.json to override default settings #4
Comments
|
Yes, I completely agree. Looking forward to your PR! Also, would you be interested to become an official maintainer of this plugin? |
|
Thanks, I'd be happy to help out with maintaining the plugin where I can. I expect to be able to send a PR for this change shortly. |
johanneskoester
added a commit
that referenced
this issue
Aug 14, 2024
Ensure that settings in ~/.irods/irods_environment.json have higher priority than default setting values, so that users don't have to copy settings from the environment file to the Snakefile. (This is a proposed fix for issue #4) Co-authored-by: Johannes Köster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the current version of the iRODS storage plugin, default setting values other than
Nonehave priority over configured settings in theirods_environment.jsonfile. For example: even ifirods_environment.jsonhasirods_authentication_schemeset topam, the plugin will still usenative(the default value inStorageProviderSettings).I think it would be useful to have the plugin always use settings in the environment file, so that users don't have to copy settings from the iRODS environment file to (for example) the Snakefile. This could either be default behaviour or could be controlled by a boolean plugin setting that controls whether or not iRODS environment file settings have priority.
If this proposed change is okay, I'd be happy to submit a PR.
The text was updated successfully, but these errors were encountered: