Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Asset Serialization to Text #6

Open
brebory opened this issue Dec 31, 2020 · 1 comment
Open

Change Asset Serialization to Text #6

brebory opened this issue Dec 31, 2020 · 1 comment
Labels
workflow Process and/or project workflow improvements
Milestone
v0.0.1

Comments

@brebory
Copy link
Member

brebory commented Dec 31, 2020

Currently our assets are serialized as binary files, which makes them basically impossible to review in a code review. The project settings should be changed so that asset files are serialized to yaml instead which will make them possible to review.
@brebory brebory added the workflow Process and/or project workflow improvements label Dec 31, 2020
@brebory brebory added this to the v0.0.1 milestone Dec 31, 2020
@brebory
Copy link
Member Author

brebory commented Dec 31, 2020

For example, see #4, the changes to the scene and the new asset file are not easily reviewable on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
workflow Process and/or project workflow improvements
Projects
None yet
Milestone
v0.0.1
Development

No branches or pull requests
1 participant
@brebory