Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #161
The previous implementation only implemented unsafe methods for registering file descriptors with
Poller
. This implements anadd_outlives
method that can guarantee safety by accepting a reference to anAsSource
which outlives thePoller
. Since file descriptors are guaranteed to be valid through the lifetime of thePoller
, there is no need to ever delete to maintain soundness.Please advise if I should change anything.