Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On kqueue platforms, make it so the EV_EOF flag corresponds to the "is_interrupt" flag. #221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

On kqueue platforms, make it so the EV_EOF flag corresponds to the "is_interrupt" flag. #221

wants to merge 1 commit into from

Conversation

notgull
Copy link
Member

@notgull notgull commented Dec 4, 2024

Closes #213

@notgull notgull requested a review from fogti December 8, 2024 16:31
@fogti
Copy link
Member

fogti commented Dec 8, 2024

Can you point to any documentation / man-page or mailing list post which proves this? I couldn't find anything indicating this association in kqueue(2) of FreeBSD 14.2. (It is of course still a good idea to be able to specify the flag, I just don't see why this is termed "interrupt"; on the other hand, relation to HUP is a bit stronger, because it gets emitted when the end of the stream is reached, e.g. because all writers of a FIFO or such closed)

@notgull
Copy link
Member Author

notgull commented Dec 13, 2024

I swear that I saw some code using it like this, but I can't seem to find it now. Standby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fogti fogti Awaiting requested review from fogti

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it so Event::is_interrupt corresponds to EV_EOF on kqueue platforms
2 participants
@notgull @fogti