Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ProcessSocketNotifications on Windows? #208

Open
Berrysoft opened this issue Jun 9, 2024 · 1 comment · May be fixed by #210
Open

Use ProcessSocketNotifications on Windows? #208

Berrysoft opened this issue Jun 9, 2024 · 1 comment · May be fixed by #210

Comments

@Berrysoft
Copy link

Berrysoft commented Jun 9, 2024

ProcessSocketNotifications is a new Windows API after 21H1. It performs much like epoll and kqueue, and provides edge trigger.

I would like to implememt it, together with #141. I think it will almost be a total rewrite of current IOCP impl. Would you like this idea?

Ref: https://learn.microsoft.com/en-us/windows/win32/api/winsock2/nf-winsock2-processsocketnotifications

@notgull
Copy link
Member

notgull commented Jun 10, 2024

I will accept a PR for this, since it looks like it can be implemented on top of the current impl. However since we still support Rust 1.63 and therefore Windows 7/10, we should keep around the old impl.

@Berrysoft Berrysoft linked a pull request Jun 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants