-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expose other kqueue filters #112
Conversation
4ee339f
to
0a367ca
Compare
The new |
Now that I look at it, maybe tying this to Thoughts? Maybe we can call this type |
That sounds pretty bad, it should terminate either with {an I/O error or a panic} if possible... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo all one-lines which can end up in a hot path (e.g. Registration::modify
) should be marked #[inline]
This PR builds on the work done in smol-rs/polling#83 in order to be able to wait on
kqueue
events aside from file descriptor readiness. It accomplishes this by replacing theraw
field inSource
with aRegistration
field that, onkqueue
platforms, accommodates all of the currently defined filters. This allows things like signals andChild
s to be handled byAsync<T>
as well.Draft until there is a new release of
polling
. I also need to test it on a BSD virtual machine.