Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

Provide option for using non-deprecated amazon instances with fck-nat #1195

Closed
wants to merge 3 commits into from

Conversation

mwillbanks
Copy link

fck-nat provides the same behavior as the amazon nat instances, with the exception that it is up to date and can be run on the arm64 platforms thus reducing overall cost. since several people already have the existing deployed, it makes more sense to provide an option to allow them to use it.

When using createNatInstance = true AND createNatInstanceFckNat = true, this will then utilize the FckNat instances rather than the deprecated amazon instances.

@jplock
Copy link
Member

jplock commented Oct 23, 2023

What do you think about making this the default to replace the amazon-managed AMI?

@mwillbanks
Copy link
Author

@jplock i think it's the right idea, my only concern was those that already have one running and swapping instance types could create some temporary downtime for them, therefore I thought it would be best not to touch it and instead add an additional option....

I actually had started thinking about extending the option support as well to make the entirety of the nat interface configurable since you can actually run the fck-nat on different instance types as well (but thats for another time).

@jplock
Copy link
Member

jplock commented Dec 20, 2023

I'm going to close this PR. Thank you for the contribution. I'm going to archive this repo as I no longer use this plugin.

@jplock jplock closed this Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants