Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option vs environment #11

Open
richfitz opened this issue May 23, 2015 · 3 comments
Open

Option vs environment #11

richfitz opened this issue May 23, 2015 · 3 comments

Comments

@richfitz
Copy link
Collaborator

Any reason for using options / getOption to store the global state and not a package environment? I feel like the latter is more typical and is generally easier to work with.

This is probably just a stylistic difference, though I feel that the semantics around the two differ (options users are allowed to poke with, environments are package internals).

Again, happy to work up a PR with this, as it's a really straightforward change. There would be no user-visible differences.

@smbache
Copy link
Owner

smbache commented May 23, 2015

I am not sure I have a strong opinion about this.

@smbache
Copy link
Owner

smbache commented Jul 7, 2015

Do you have a prefererence to change this?

@richfitz
Copy link
Collaborator Author

richfitz commented Jul 7, 2015

I think I'd prefer an environment. I can contribute the change if you're happy with it being changed, otherwise if you'd rather keep it as done via options, just close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants