Skip to content

Commit c4fe7b7

Browse files
Feature/df 18966 coinmetrics ea failing to serve valid requests (#3034)
* fixed failing to serve new valid requests after being hit with invalid request * test cases for generated urls with invalid requests * requested changes to code * update unit test * requested changes to code * Coinmetrics EA failing to serve new valid requests after being hit with invalid request. * changeset added * lint issue * changes as per review
1 parent c75677b commit c4fe7b7

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

.changeset/gold-jars-float.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@chainlink/coinmetrics-adapter': minor
3+
---
4+
5+
Coinmetrics EA failing to serve new valid requests after being hit with invalid request.

packages/sources/coinmetrics/src/transport/price-ws.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -91,15 +91,15 @@ export const handleAssetMetricsMessage = (
9191
logger.error(message, `Error response from websocket`)
9292

9393
const findBaseCurrenciesRegex = new RegExp(/'([^']+)'/g)
94-
if (message['error']['type'] === 'bad_parameters') {
94+
if (message['error']['type'] === 'bad_parameter') {
9595
//Bad Parameter Error Message
96-
// {error: {
97-
// type: "bad_parameter",
98-
// message: "Metric 'ReferenceRateBTC' with frequency '1s' is not supported for 'cron'."}}
96+
// type: 'bad_paramter'
97+
// message: 'Bad parameter 'assets'. Value 'ohmv2' is not supported.'
98+
9999
const matches = [...message.error.message.matchAll(findBaseCurrenciesRegex)]
100100

101-
if (matches && !invalidBaseAssets.includes(matches[2][1])) {
102-
invalidBaseAssets.push(matches[2][1])
101+
if (matches && !invalidBaseAssets.includes(matches[1][1])) {
102+
invalidBaseAssets.push(matches[1][1])
103103
}
104104
}
105105
} else if ('warning' in message) {

0 commit comments

Comments
 (0)