Market-status composite defaults to unknown status (#3484)

Author: martin-cll

.changeset/poor-roses-brake.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/market-status-adapter': minor
+---
+
+Default to unknown status instead of closed

packages/composites/market-status/src/transport/market-status.ts

@@ -98,11 +98,11 @@ export class MarketStatusTransport extends SubscriptionTransport<BaseEndpointTyp
     }
 
     logger.error(
-      `Secondary adapter ${adapterNames.secondary} for market ${market} returned unknown market status, defaulting to CLOSED`,
+      `Secondary adapter ${adapterNames.secondary} for market ${market} returned unknown market status, defaulting to UNKNOWN`,
     )
 
     return {
-      marketStatus: MarketStatus.CLOSED,
+      marketStatus: MarketStatus.UNKNOWN,
       providerIndicatedTimeUnixMs: Date.now(),
     }
   }

packages/composites/market-status/test/integration/adapter.test.ts

@@ -6,8 +6,6 @@ import {
 import FakeTimers from '@sinonjs/fake-timers'
 
 import * as fixtures from './fixtures'
-import { MockCache } from '@chainlink/external-adapter-framework/util/testing-utils'
-import { runAllUntil } from '@chainlink/external-adapter-framework/util/testing-utils'
 
 describe('execute', () => {
   let clock: FakeTimers.InstalledClock
@@ -107,7 +105,7 @@ describe('execute', () => {
     })
   })
 
-  it.only('returns ncfx if tradinghours is failing', async () => {
+  it('returns ncfx if tradinghours is failing', async () => {
     const market = 'test-4'
     fixtures.mockTradinghoursError(market)
     fixtures.mockNCFXOpen(market)
@@ -128,17 +126,17 @@ describe('execute', () => {
     })
   })
 
-  it('returns closed if tradinghours is failing and ncfx is failing', async () => {
+  it('returns unknown if tradinghours is failing and ncfx is failing', async () => {
     const market = 'test-5'
     fixtures.mockTradinghoursError(market)
     fixtures.mockNCFXError(market)
 
     const response = await waitForSuccessfulRequest({ market })
     expect(response.json()).toEqual({
       data: {
-        result: 1,
+        result: 0,
       },
-      result: 1,
+      result: 0,
       statusCode: 200,
       timestamps: {
         providerDataReceivedUnixMs: expect.any(Number),
@@ -148,17 +146,17 @@ describe('execute', () => {
     })
   })
 
-  it('returns closed if tradinghours is failing and ncfx is unknown', async () => {
+  it('returns unknown if tradinghours is failing and ncfx is unknown', async () => {
     const market = 'test-6'
     fixtures.mockTradinghoursError(market)
     fixtures.mockNCFXUnknown(market)
 
     const response = await waitForSuccessfulRequest({ market })
     expect(response.json()).toEqual({
       data: {
-        result: 1,
+        result: 0,
       },
-      result: 1,
+      result: 0,
       statusCode: 200,
       timestamps: {
         providerDataReceivedUnixMs: expect.any(Number),