DLC.BTC throw on RPC errors (#3469)

* rpc error handling

* change changeset version to minor

Author: karen-stepanyan

.changeset/sour-scissors-teach.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/dlc-btc-por-adapter': minor
+---
+
+Changed error handling for missing transactions or RPC issues

packages/sources/dlc-btc-por/src/transport/proof-of-reserves.ts

@@ -107,12 +107,7 @@ export class DLCBTCPorTransport extends SubscriptionTransport<TransportTypes> {
       }
       const deposits = await Promise.all(
         group.map(async (vault) => {
-          try {
-            return await this.verifyVaultDeposit(vault, attestorPublicKey)
-          } catch (e) {
-            logger.error(e, `Error while verifying Deposit for Vault: ${vault.uuid}. ${e}`)
-            return 0
-          }
+          return await this.verifyVaultDeposit(vault, attestorPublicKey)
         }),
       )
       // totalPoR represents total proof of reserves value in bitcoins
@@ -165,6 +160,10 @@ export class DLCBTCPorTransport extends SubscriptionTransport<TransportTypes> {
     // Get the bitcoin transaction
     const fundingTransaction = await this.fetchFundingTransaction(txID)
 
+    if (!fundingTransaction) {
+      throw new Error(`Funding transaction not found for vault ${vault.uuid}`)
+    }
+
     // Check and filter transactions that have less than [settings.CONFIRMATIONS] confirmations
     if (fundingTransaction.confirmations < this.settings.CONFIRMATIONS) {
       return 0

packages/sources/dlc-btc-por/test/integration/adapter.test.ts

@@ -3,7 +3,49 @@ import {
   setEnvVariables,
 } from '@chainlink/external-adapter-framework/util/testing-utils'
 import * as nock from 'nock'
-import { mockBitcoinRPCResponseSuccess, mockContractCallResponseSuccess } from './fixtures'
+import { mockBitcoinRPCResponseSuccess } from './fixtures'
+import { ethers } from 'ethers'
+
+jest.mock('ethers', () => {
+  const actualModule = jest.requireActual('ethers')
+  return {
+    ...actualModule,
+    ethers: {
+      ...actualModule.ethers,
+      providers: {
+        JsonRpcProvider: function (): ethers.providers.JsonRpcProvider {
+          return {} as ethers.providers.JsonRpcProvider
+        },
+      },
+      Contract: function () {
+        return {
+          attestorGroupPubKey: jest.fn().mockImplementation(() => {
+            return 'xpub6C1F2SwADP3TNajQjg2PaniEGpZLvWdMiFP8ChPjQBRWD1XUBeMdE4YkQYvnNhAYGoZKfcQbsRCefserB5DyJM7R9VR6ce6vLrXHVfeqyH3'
+          }),
+          getAllDLCs: jest.fn().mockImplementation(() => {
+            return [
+              {
+                uuid: '0x9399fc7c386e7357fc101e638f3e208dcb95fbe06c47e3ff4219d5c726635222',
+                protocolContract: '0x2940FcBb3C32901Df405da0E96fd97D1E2a53f34',
+                timestamp: 0x665f1dd7,
+                valueLocked: 0x01312d00,
+                creator: '0x0DD4f29E21F10cb2E485cf9bDAb9F2dD1f240Bfa',
+                status: 1,
+                fundingTxId: '2d64eefe48cd209c4d549b065d3c04dcb29af57b01ca2a98c24274eae2732029',
+                closingTxId: '',
+                btcFeeRecipient:
+                  '021b34f36d8487ce3a7a6f0124f58854d561cb52077593d1e86973fac0fea1a8b1',
+                btcMintFeeBasisPoints: 0x64,
+                btcRedeemFeeBasisPoints: 0x64,
+                taprootPubKey: 'b362931e3e4cf3cc20f75ae11ff5a4c115ec1548cb5f2c7c48294929f1e8979c',
+              },
+            ]
+          }),
+        }
+      },
+    },
+  }
+})
 
 describe('execute', () => {
   let spy: jest.SpyInstance
@@ -40,7 +82,6 @@ describe('execute', () => {
 
   describe('por endpoint', () => {
     it('should return success', async () => {
-      mockContractCallResponseSuccess()
       mockBitcoinRPCResponseSuccess()
       const response = await testAdapter.request({
         network: 'arbitrum',