diff --git a/pkg/workflows/wasm/host/wasip1.go b/pkg/workflows/wasm/host/wasip1.go index 008c0fc4c..016ca2ca3 100644 --- a/pkg/workflows/wasm/host/wasip1.go +++ b/pkg/workflows/wasm/host/wasip1.go @@ -2,6 +2,7 @@ package host import ( "encoding/binary" + "fmt" "io" "math/rand" "time" @@ -122,9 +123,11 @@ func pollOneoff(caller *wasmtime.Caller, subscriptionptr int32, eventsptr int32, eventType := subs[inOffset+8] argBuf := subs[inOffset+8+8:] - outOffset := events[i*eventsLen] + slot, err := getSlot(events, i) + if err != nil { + return ErrnoFault + } - slot := events[outOffset:] switch eventType { case eventTypeClock: // We want to stub out clock events, @@ -228,3 +231,14 @@ func createRandomGet(cfg *ModuleConfig) func(caller *wasmtime.Caller, buf, bufLe return ErrnoSuccess } } + +func getSlot(events []byte, i int32) ([]byte, error) { + offset := i * eventsLen + + if offset+eventsLen > int32(len(events)) { + return nil, fmt.Errorf("slot %d out of bounds", i) + } + + slot := events[offset : offset+eventsLen] + return slot, nil +} diff --git a/pkg/workflows/wasm/host/wasip1_test.go b/pkg/workflows/wasm/host/wasip1_test.go new file mode 100644 index 000000000..bfe9292d0 --- /dev/null +++ b/pkg/workflows/wasm/host/wasip1_test.go @@ -0,0 +1,31 @@ +package host + +import ( + "testing" + + "github.com/stretchr/testify/assert" +) + +func TestGetSlot(t *testing.T) { + events := []byte{ + 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, + 250, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, + } + + t.Run("getSlot works correctly", func(t *testing.T) { + expectedSlots := [][]byte{ + {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31}, + {250, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63}, + } + + for i := int32(0); i < 2; i++ { + slot, err := getSlot(events, i) + assert.NoError(t, err) + assert.Equal(t, expectedSlots[i], slot) + } + }) + t.Run("check for out of bound slot", func(t *testing.T) { + _, err := getSlot(events, 400) + assert.Error(t, err) + }) +}