Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smallrye-mutiny-vertx-bindings of io.vertx:vertx-web-openapi-router #920

Open
tnmtechnologies opened this issue Apr 2, 2024 · 12 comments
Open

Comments

@tnmtechnologies
Copy link

tnmtechnologies commented Apr 2, 2024

Is it planned to provide smallrye-mutiny-vertx-bindings of io.vertx:vertx-web-openapi-router ?

https://vertx.io/docs/vertx-web-openapi-router/java/

Thanks.

@jponge
Copy link
Member

jponge commented Apr 4, 2024

Which parts of the API would need to be Uni/Multi returning?

@tnmtechnologies
Copy link
Author

Sorry I don't know.
Today, our software is fully based on io.smallrye.reactive:smallrye-mutiny-vertx-web-openapi.
We plan to use the smallrye-mutiny-vertx-bindings of io.vertx:vertx-web-openapi-router when it is available because of vert-x3/vertx-web#2383 (comment).
Hope my reply will help you.

@pk-work
Copy link
Contributor

pk-work commented May 3, 2024

Hi, I opened a PR #926

@AdrianVasiliu
Copy link

Given the revert via #930, the fix isn't available in v4.5.8. We face the issue vert-x3/vertx-web#2383, that this was supposed to resolve. An ETA for the fix? Thanks.

@cescoffier
Copy link
Contributor

This will be done when we start updating Quarkus to the latest Vert.x. It should happen next week.

@cescoffier
Copy link
Contributor

Unfortunately, even with the update it does not go well:

[ERROR] /Users/clement/Development/smallrye/smallrye-mutiny-vertx-bindings/vertx-mutiny-clients/vertx-mutiny-openapi/target/generated-sources/apt/io/vertx/mutiny/openapi/contract/OpenAPIContract.java:[82,53] non-static variable delegate cannot be referenced from a static context
[ERROR] /Users/clement/Development/smallrye/smallrye-mutiny-vertx-bindings/vertx-mutiny-clients/vertx-mutiny-openapi/target/generated-sources/apt/io/vertx/mutiny/openapi/contract/OpenAPIContract.java:[82,66] illegal static interface method call
[ERROR]   the receiver expression should be replaced with the type qualifier 'io.vertx.openapi.contract.OpenAPIContract'
[ERROR] /Users/clement/Development/smallrye/smallrye-mutiny-vertx-bindings/vertx-mutiny-clients/vertx-mutiny-openapi/target/generated-sources/apt/io/vertx/mutiny/openapi/contract/OpenAPIContract.java:[122,53] non-static variable delegate cannot be referenced from a static context
[ERROR] /Users/clement/Development/smallrye/smallrye-mutiny-vertx-bindings/vertx-mutiny-clients/vertx-mutiny-openapi/target/generated-sources/apt/io/vertx/mutiny/openapi/contract/OpenAPIContract.java:[122,66] illegal static interface method call
[ERROR]   the receiver expression should be replaced with the type qualifier 'io.vertx.openapi.contract.OpenAPIContract'
[ERROR] /Users/clement/Development/smallrye/smallrye-mutiny-vertx-bindings/vertx-mutiny-clients/vertx-mutiny-openapi/target/generated-sources/apt/io/vertx/mutiny/openapi/contract/OpenAPIContract.java:[166,53] non-static variable delegate cannot be referenced from a static context
[ERROR] /Users/clement/Development/smallrye/smallrye-mutiny-vertx-bindings/vertx-mutiny-clients/vertx-mutiny-openapi/target/generated-sources/apt/io/vertx/mutiny/openapi/contract/OpenAPIContract.java:[166,66] illegal static interface method call
[ERROR]   the receiver expression should be replaced with the type qualifier 'io.vertx.openapi.contract.OpenAPIContract'
[ERROR] /Users/clement/Development/smallrye/smallrye-mutiny-vertx-bindings/vertx-mutiny-clients/vertx-mutiny-openapi/target/generated-sources/apt/io/vertx/mutiny/openapi/contract/OpenAPIContract.java:[212,53] non-static variable delegate cannot be referenced from a static context
[ERROR] /Users/clement/Development/smallrye/smallrye-mutiny-vertx-bindings/vertx-mutiny-clients/vertx-mutiny-openapi/target/generated-sources/apt/io/vertx/mutiny/openapi/contract/OpenAPIContract.java:[212,66] illegal static interface method call
[ERROR]   the receiver expression should be replaced with the type qualifier 'io.vertx.openapi.contract.OpenAPIContract'
[ERROR] /Users/clement/Development/smallrye/smallrye-mutiny-vertx-bindings/vertx-mutiny-clients/vertx-mutiny-openapi/target/generated-sources/apt/io/vertx/mutiny/openapi/validation/ValidatableRequest.java:[73,53] non-static variable delegate cannot be referenced from a static context
[ERROR] /Users/clement/Development/smallrye/smallrye-mutiny-vertx-bindings/vertx-mutiny-clients/vertx-mutiny-openapi/target/generated-sources/apt/io/vertx/mutiny/openapi/validation/ValidatableRequest.java:[73,64] illegal static interface method call
[ERROR]   the receiver expression should be replaced with the type qualifier 'io.vertx.openapi.validation.ValidatableRequest'
[ERROR] -> [Help 1]

@pk-work
Copy link
Contributor

pk-work commented Jun 10, 2024

Can I check it out and test it locally?

@cescoffier
Copy link
Contributor

Sure, just take the main branch and readd the modules. Do a mvn install -DskipTests (there are no tests in these modules) and you will see the compilation issue.

@AdrianVasiliu
Copy link

AdrianVasiliu commented Jun 25, 2024

@cescoffier @pk-work Our Vertx apps are annoyingly impacted by this bug. Any hope the issue would be resolved in the near future?
And: waiting for the fix, a workaround?

@cescoffier
Copy link
Contributor

The added modules aren't functional yet. The generation fails and I don't know the root cause. The upstream code may not follow the generation rules (I already reported issues). Unfortunately, it means fixing it in Vertx, wait for a release, then test here, repeat...

@pk-work
Copy link
Contributor

pk-work commented Jun 25, 2024

@AdrianVasiliu Hi, sorry for the inconvenience. Due to private circumstances I wasn't able to spent much time into my opensource activities and I don't know when this will change. Maybe 2 weeks, maybe a month. I don't know.

If this is only a smaller issue with e.g. visibility of classes / methods and really important for you, please open a PR in vertx-openapi and/or vertx-web and I will review it.

@AdrianVasiliu
Copy link

AdrianVasiliu commented Jun 25, 2024

Hi @pk-work, thanks for the feedback. I follow this issue because we were following vert-x3/vertx-web#2383 which has been closed with the PR reverted due to this issue (if I got well your comment there). I don't have the big picture in my hands.
In the end, for our app, it's about being able to upgrade to a Vertx version where io.vertx.core.VertxException: Thread blocked doesn't hurt any more...

@cescoffier Thanks for your info too. Well, it looks we'll need to look for workarounds / changes on our side to avoid being hit by the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants