-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smallrye-mutiny-vertx-bindings of io.vertx:vertx-web-openapi-router #920
Comments
Which parts of the API would need to be |
Sorry I don't know. |
Hi, I opened a PR #926 |
Given the revert via #930, the fix isn't available in v4.5.8. We face the issue vert-x3/vertx-web#2383, that this was supposed to resolve. An ETA for the fix? Thanks. |
This will be done when we start updating Quarkus to the latest Vert.x. It should happen next week. |
Unfortunately, even with the update it does not go well:
|
Can I check it out and test it locally? |
Sure, just take the main branch and readd the modules. Do a mvn install -DskipTests (there are no tests in these modules) and you will see the compilation issue. |
@cescoffier @pk-work Our Vertx apps are annoyingly impacted by this bug. Any hope the issue would be resolved in the near future? |
The added modules aren't functional yet. The generation fails and I don't know the root cause. The upstream code may not follow the generation rules (I already reported issues). Unfortunately, it means fixing it in Vertx, wait for a release, then test here, repeat... |
@AdrianVasiliu Hi, sorry for the inconvenience. Due to private circumstances I wasn't able to spent much time into my opensource activities and I don't know when this will change. Maybe 2 weeks, maybe a month. I don't know. If this is only a smaller issue with e.g. visibility of classes / methods and really important for you, please open a PR in vertx-openapi and/or vertx-web and I will review it. |
Hi @pk-work, thanks for the feedback. I follow this issue because we were following vert-x3/vertx-web#2383 which has been closed with the PR reverted due to this issue (if I got well your comment there). I don't have the big picture in my hands. @cescoffier Thanks for your info too. Well, it looks we'll need to look for workarounds / changes on our side to avoid being hit by the bug. |
Is it planned to provide smallrye-mutiny-vertx-bindings of io.vertx:vertx-web-openapi-router ?
https://vertx.io/docs/vertx-web-openapi-router/java/
Thanks.
The text was updated successfully, but these errors were encountered: