Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationship of VSA's resourceUri with the attestation subject #1219

Open
adityasaky opened this issue Oct 24, 2024 · 1 comment
Open

Relationship of VSA's resourceUri with the attestation subject #1219

adityasaky opened this issue Oct 24, 2024 · 1 comment

Comments

@adityasaky
Copy link
Member

The artifact a VSA applies to is identified using the resourceUri in the attestation predicate (per https://slsa.dev/spec/v1.0/verification_summary#fields). Should the VSA spec add guidance about how resourceUri is related to entries in the attestation's subject field? A subject can have its own uri as well, should this match?

Alternatively, should we deprecate resourceUri in favor of subject? This would be consistent with how we treat provenance for artifacts AIUI. This would also enable generating a single VSA when verifying multiple artifacts against the same policy.

@TomHennen
Copy link
Contributor

I suppose if it's causing confusion we should definitely say something.

In our usage the subject.uri field has no relation whatsoever to the resourceUri. Users are free to have the subject.uri set to whatever they like.

I'd prefer we not replace resourceUri with subject.uri. I seem to remember this being discussed to quite some extent before, but I cannot find the discussion. If we want we can document that rationale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants