Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle submodules in the source track? #1134

Open
TomHennen opened this issue Sep 19, 2024 · 3 comments
Open

How to handle submodules in the source track? #1134

TomHennen opened this issue Sep 19, 2024 · 3 comments

Comments

@TomHennen
Copy link
Contributor

          Should we address submodules and other 'indirection' elsewhere in the spec or is it better to keep it aligned with the attestations themselves?

Originally posted by @TomHennen in #1094 (comment)

@zachariahcox
Copy link
Contributor

zachariahcox commented Sep 19, 2024

Some thoughts on this topic.

Submodules are just files. In that sense, nothing special is needed.

However, if you direct a tool to act on the content of those files (EG: git clone --recurse-submodules), you will end up with other repos in your repo.
In this sense, submodule objects are similar to dependency lock files.

Not all submodules are required (it might not be necessary to clone every submodule) and there are other ways to get the nested repo pattern needed by a project (EG: just clone them directly from a makefile).

Can one revision be slsa-level-3 if it references a submodule at slsa-level-1?

I think we say that slsa levels are not transitive like that, so the answer is "yes."

@TomHennen
Copy link
Contributor Author

I'd agree, so long as we require that the builder include each submodule repo as a separate 'resolvedDependency' so that it's easy for package verifiers to know that all these other repos were used.

Would that be reasonable?

@zachariahcox zachariahcox moved this to In review in SLSA Source Track Sep 23, 2024
@zachariahcox zachariahcox moved this from In review to Ready for work! in SLSA Source Track Nov 6, 2024
@TomHennen
Copy link
Contributor Author

Where should we document this? A 'faq' section?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Status: Ready for work!
Development

No branches or pull requests

2 participants